Master #2270
Master #2270
Conversation
|
Wow, this looks like a ton of work. Thanks Matt! |
| @@ -1,3 +1,6 @@ | |||
| /** | |||
| * @file Needed for full path retrieval | |||
There was a problem hiding this comment.
Saying this each time isn't ideal. Can you explain why it's needed, and should we try to put real file descriptions for each of these? It could be event as generic as the file name.
|
I noticed that all the jsdoc comments are now all formatted with no space infront of the asterisks after the first line. We really want them to be standard jsdoc tags, which do have a space. Would you be able to make that update? Otherwise this looks good to merge in. |
|
Merged in. Thanks @mboles! |
| import Button from './button.js'; | ||
| import Component from './component.js'; | ||
|
|
||
| /* Big Play Button | ||
| ================================================================================ */ | ||
| / * Big Play Button |
There was a problem hiding this comment.
@mboles FYI, the find replace wasn't 100% safe. It added a comment-breaking space in a few places like this. I cleaned them up, but just a heads up in case you use that again.
Added JSDoc comments to files at the root of the src/js directory